Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clerk-js): Support verification with enterprise SSO #4406

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(clerk-js): Support verification with enterprise SSO #4406

wants to merge 3 commits into from
+207 −16

Conversation

NicolasLopes7
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 commented Oct 24, 2024 •
edited by LauraBeatris
Loading

Description

Resolves ORGS-395

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0d9bdfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NicolasLopes7 NicolasLopes7 changed the title wip orgs-236: wip Oct 24, 2024
@LauraBeatris LauraBeatris changed the title orgs-236: wip feat(clerk-js): Support verification with enterprise SSO Dec 2, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 1:08pm

@LauraBeatris LauraBeatris changed the title feat(clerk-js): Support verification with enterprise SSO feat(clerk-js): Support verification with enterprise SSO Dec 2, 2024
LauraBeatris
LauraBeatris reviewed Dec 2, 2024
View reviewed changes
packages/clerk-js/src/ui/components/UserProfile/EmailForm.tsx Outdated
const emailAddressRef = React.useRef<EmailAddressResource | undefined>(user?.emailAddresses.find(a => a.id === id));
const strategy = getVerificationStrategy(emailAddressRef.current, preferEmailLinks);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: We could map each component based on the strategy instead of performing multiple conditionals.

Also should take a look at not using the ref, but actually using the email within user settings.

LauraBeatris
LauraBeatris reviewed Dec 2, 2024
View reviewed changes
packages/clerk-js/src/ui/components/UserProfile/VerifyWithEnterpriseConnection.tsx Outdated
*/
const { routing } = profileContext;
const baseUrl = routing === 'virtual' ? displayConfig.userProfileUrl : '';
const redirectUrl = buildEmailLinkRedirectUrl(profileContext, baseUrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: We should rename buildEmailLinkRedirectUrl to buildVerificationRedirectUrl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LauraBeatris LauraBeatris LauraBeatris left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LauraBeatris LauraBeatris

@NicolasLopes7 NicolasLopes7

Labels
clerk-js types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasLopes7 @LauraBeatris @clerk-cookie