Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(testing): add note about running test setup in serial mode #1798

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(testing): add note about running test setup in serial mode #1798

merged 2 commits into from
Dec 12, 2024

Conversation

brkalow
Copy link
Member

@brkalow brkalow commented Dec 11, 2024 •
edited
Loading

Important

🔎 Previews:

Explanation:

  • Improves our testing docs by ensuring the global setup is run serially, even if playwright is configured to run in parallel.

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@brkalow brkalow requested a review from a team as a code owner December 11, 2024 21:49
@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1798

alexisintech
alexisintech approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸💖

@alexisintech alexisintech merged commit a34d0fd into main Dec 12, 2024
5 checks passed
@alexisintech alexisintech deleted the brk.fix/playwright-serial branch December 12, 2024 14:29
royanger pushed a commit that referenced this pull request Dec 16, 2024
@brkalow @royanger
fix(testing): add note about running test setup in serial mode (#1798)
66bc151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisintech alexisintech alexisintech approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brkalow @alexisintech