Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SSO per org #1755

Merged
merged 25 commits into from
Dec 18, 2024
Merged

Conversation

Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1755

@LauraBeatris LauraBeatris changed the title [wip] feat: SSO per org feat: SSO per org Dec 11, 2024
@LauraBeatris LauraBeatris marked this pull request as ready for review December 11, 2024 13:37
@LauraBeatris LauraBeatris requested a review from a team as a code owner December 11, 2024 13:37
Copy link
Contributor

@victoriaxyz victoriaxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LauraBeatris, this PR looks good! Thanks for answering my questions earlier.

Here's the commit for my update: #1755

Update

  • docs/organizations/enterprise-sso.mdx: reorganized and rewrote doc
  • organizations/overview: rewrote Enterprise SSO section
  • authentication/enterprise-connections/authentication-flows: added OIDC section
  • organizations/verified-domains: updated the warning

For the following docs, I updated the setup instructions (some of these docs need to be redone, ticket: DOCS-9500

  • authentication/enterprise-connections/easie/google
  • authentication/enterprise-connections/easie/microsoft
  • authentication/enterprise-connections/saml/azure
  • authentication/enterprise-connections/saml/custom-provider
  • authentication/enterprise-connections/saml/google
  • authentication/enterprise-connections/saml/okta

Note

  • Maybe add recommended approach to the SSO onboarding flows

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LauraBeatris LauraBeatris force-pushed the laura/orgs-244-update-docs-for-sso-per-org branch 4 times, most recently from da8e299 to 1fc9a23 Compare December 18, 2024 15:41
@LauraBeatris LauraBeatris force-pushed the laura/orgs-244-update-docs-for-sso-per-org branch from 1fc9a23 to fcb506a Compare December 18, 2024 15:42
@LauraBeatris LauraBeatris merged commit dfc5452 into main Dec 18, 2024
4 checks passed
@LauraBeatris LauraBeatris deleted the laura/orgs-244-update-docs-for-sso-per-org branch December 18, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants