Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update expo docs #1666

Merged
merged 29 commits into from
Dec 6, 2024
Merged

update expo docs #1666

merged 29 commits into from
Dec 6, 2024

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Oct 28, 2024

🔎 https://clerk.com/docs/pr/1666/quickstarts/expo

  • Remove step about creating Expo app - it didn't align with the quickstart doc, nor the repo
  • Align with other quickstarts

🔎 https://clerk.com/docs/pr/1666/references/expo/read-session-user-data

  • Minor copy updates

🔎 https://clerk.com/docs/pr/1666/references/expo/use-oauth

  • Documents the useOAuth() helper

🔎 https://clerk.com/docs/pr/1666/references/expo/use-local-credentials

🔎 https://clerk.com/docs/pr/1666/custom-flows/email-password
🔎 https://clerk.com/docs/pr/1666/custom-flows/email-password-mfa
🔎 https://clerk.com/docs/pr/1666/custom-flows/manage-totp-based-mfa
🔎 https://clerk.com/docs/pr/1666/custom-flows/oauth-connections
🔎 https://clerk.com/docs/pr/1666/custom-flows/user-impersonation

  • Tested and updated flows; aligned them with the other examples (code comments, text used in components)

🔎 https://clerk.com/docs/pr/1666/references/javascript/types/metadata

  • Documents types related to metadata, and updates all docs that reference them

@alexisintech alexisintech changed the title wip - Update Apple OAuth guide wip - update expo Oct 30, 2024
@alexisintech alexisintech changed the title wip - update expo wip - update expo docs Oct 30, 2024
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1666

docs/custom-flows/email-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/manage-totp-based-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/manage-totp-based-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/manage-totp-based-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
@alexisintech alexisintech changed the title wip - update expo docs update expo docs Dec 6, 2024
@alexisintech alexisintech marked this pull request as ready for review December 6, 2024 19:53
@alexisintech alexisintech requested review from a team as code owners December 6, 2024 19:53
docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password-mfa.mdx Outdated Show resolved Hide resolved
docs/custom-flows/email-password.mdx Outdated Show resolved Hide resolved
docs/custom-flows/user-impersonation.mdx Outdated Show resolved Hide resolved
docs/custom-flows/user-impersonation.mdx Outdated Show resolved Hide resolved
import { Button, Text, View } from 'react-native'
import { useRouter } from 'expo-router'
import { useUser, useSignIn } from '@clerk/clerk-expo'
import useUsers from '../hooks/useUsers'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import useUsers from '../hooks/useUsers'
import useUsers from '../../hooks/useUsers'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show me why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

@alexisintech alexisintech Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 I see, hooks/ isn't inside app/.
should it be? or should we keep in the root?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to move hooks/ to /app.

docs/quickstarts/expo.mdx Outdated Show resolved Hide resolved
docs/quickstarts/expo.mdx Outdated Show resolved Hide resolved
@victoriaxyz victoriaxyz self-requested a review December 6, 2024 23:24
@alexisintech alexisintech merged commit 3b396ab into main Dec 6, 2024
4 checks passed
@alexisintech alexisintech deleted the aa/DOCS-9323 branch December 6, 2024 23:27
alexisintech added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants