No-op: UpdateUserConfig already handles SaveIni internally#523
Closed
Copilot wants to merge 1 commit intoupdate_config_logfrom
Closed
No-op: UpdateUserConfig already handles SaveIni internally#523Copilot wants to merge 1 commit intoupdate_config_logfrom
Copilot wants to merge 1 commit intoupdate_config_logfrom
Conversation
Copilot
AI
changed the title
[WIP] Update CLEO config loading to handle SaveIni calls
No-op: UpdateUserConfig already handles SaveIni internally
Feb 26, 2026
|
🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bot-generated review suggestion on #522 proposed adding an explicit
SaveIni()call afterUpdateUserConfig()inEnsureLoaded, and removing the outerini.LoadFile(path). This was incorrect.UpdateUserConfigalready callsSaveIni()internally when the config is modified:The existing flow in
EnsureLoadedis correct as-is:ini.LoadFileloads itini.LoadFileloads user config →UpdateUserConfigmerges new keys and saves if modified → outerini.LoadFilereloads from disk (already up to date)No code changes are required. This PR documents the analysis and closes out the review thread.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.