Conversation
x87
reviewed
Mar 20, 2025
x87
reviewed
Mar 20, 2025
| set_audio_stream_progress stream {progress} 0.5 | ||
| progress = -1.0 | ||
| progress = get_audio_stream_progress_seconds stream | ||
| assert_rangef(progress, 3.6, 3.8) // test file is about 7.4 seconds long |
There was a problem hiding this comment.
I think we can also test progress_in_seconds after setting it in seconds. should be same?
Collaborator
Author
There was a problem hiding this comment.
With some margin for error. New opcodes implementation bases on combination of get/set progress and get length, so it is safer to perform verification using simpler tools. There is also possibility that same error will be mirrored in both getter/setter opcode pair.
x87
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.