Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script log problems #276

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix script log problems #276

merged 2 commits into from
Jan 27, 2025

Conversation

MiranDMC
Copy link
Collaborator

No description provided.

@MiranDMC MiranDMC requested a review from x87 January 27, 2025 00:22
@MiranDMC MiranDMC force-pushed the Fix_scriptLog_problems branch from c251f49 to 5d405d0 Compare January 27, 2025 00:48
@x87
Copy link

x87 commented Jan 27, 2025

we should probably lower the limit from 5 sec to 1 sec (1 FPS)

@MiranDMC
Copy link
Collaborator Author

MiranDMC commented Jan 27, 2025

we should probably lower the limit from 5 sec to 1 sec (1 FPS)

This will cause reports again.
While 1FPS is not acceptable to play with it still can happen in normal scenarios that some command take longer to execute.

Call of load_all_models_now can hang up game for a moment (especially after requesting all world models).
Any network related operation also can take a while.
Enabling SCRLog with flush on everything slows down script significantly. RZL Trainer takes 16 seconds to initialize.

5 seconds seems to be good value to reflect average user patience.

@x87
Copy link

x87 commented Jan 27, 2025

Yes, I was thinking more along the lines of permanent slowness. One-time lag is probably fine

@MiranDMC MiranDMC merged commit 499d1bd into master Jan 27, 2025
1 check passed
@MiranDMC MiranDMC deleted the Fix_scriptLog_problems branch January 27, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants