code to cover #68

ghidriff/ghidra_diff_engine.py

@@ -865,8 +865,12 @@ def get_pe_download_url(
         """
 
         path = Path(path)
-        pe_info = get_pe_extra_data(path)
-        url = get_microsoft_download_url(filename, pe_info['timestamp'], pe_info['image_size'])
+        try:
+            pe_info = get_pe_extra_data(path)
+            url = get_microsoft_download_url(filename, pe_info['timestamp'], pe_info['image_size'])
+        except:
+            self.logger.warn(f'PE Parsing error. Exception thrown parsing {path.name}')
+            url = None        
 
         # from ghidra.app.util.bin.format.pe import PortableExecutable
         # from ghidra.app.util.bin import FileByteProvider

tests/test_pe_parsing.py

@@ -0,0 +1,21 @@
+import pytest
+from pathlib import Path
+
+from ghidriff import GhidraDiffEngine, VersionTrackingDiff, get_parser
+
+SYMBOLS_DIR = 'symbols'
+
+@pytest.mark.forked
+def test_parsing_pe_garbage(shared_datadir: Path):
+
+    parser = get_parser()
+
+    args = parser.parse_args(['test', 'test2']) # these args will not be tested
+
+
+    not_a_pe_path = shared_datadir / SYMBOLS_DIR / 'pingme.txt'
+
+    DiffEngine: GhidraDiffEngine = VersionTrackingDiff
+    d = DiffEngine(args=args)
+
+    assert None == d.get_pe_download_url(not_a_pe_path,'junk')