Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially addresses #862
[ 鉁忥笍 Write your summary here. ]
A significant improvement comes from vectorizing
_get_iou
,_euc_dis
and_calculate_average_precision
. I searched for all references to the deleted_mod_coordinates
and_get_overlap
but they are not used anywhere else in the code. I assumed it is ok to remove them because they are not part of the public api however let me know if you prefer to deprecate them or keep both versions.For memory I used the memory-profiler library. The code I used for benchmarking is copied below. In addition I sorted the imports in the modified files.
Code Setup
Current version
This PR
Testing
References
Reviewer Notes
I was not sure about which input would be more realistic, I have tried different options but the improvements were similar, however let me know if you want me to test a specific combination of inputs, I tried to use the largest input dataset I could while still being able to run the master %%timeit in about an hour.
I have noticed that the
num_procs
argument in_calculate_ap_per_class
is always set to the default value. Thus, i made a few changes there to ensure that the pool is only created whennum_procs
is higher than 1.After each change I ran the tests and they were catching any minor mistake I made. However once they were passing I ensured with some random input that both versions (master and this PR) still produced the same exact output.