Append end index instead of array size as last index. #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
This repo is a translation from Matlab, which uses 1-based arrays. In Matlab, the array size and last index are the same.
When considering endpoints, the first and last index are appended to the "ind" vector. The bug was that the size was used instead of the last index, causing access beyond the end of the array.
In addition, the example code defines an array of 14 elements and populates 13 elements, hiding the bug if you try to test it with that code. This change corrects the size of the example array so that endpoints can be tested.
Before:
After