Add option for print_gaugenos = 'none'
#316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjleveque
reviewed
Aug 17, 2025
| if gaugeno not in plotdata.print_gaugenos: | ||
| #print('+++ skipping gauge %i, not in print_gaugenos' % gaugeno) | ||
| continue # to next gauge | ||
| if (plotdata.print_gaugenos.lower() != 'all' or |
There was a problem hiding this comment.
kml version not working. I think or should be and here, but also if gaugeno is an int the next line doesn't work:
gaugeno not in plotdata.print_gaugenos):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'in <string>' requires string as left operand, not int
Does a little bit more where `none` and `all` case does not matter. This was added to make it so that `None` for instance is valid.
mandli
force-pushed
the
add-print_gaugenos-none
branch
from
6244195 to
f0f4b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this with @mjberger. Adds an option for
print_gaugenos = 'none'as well asFalse. Also adds some logic to allow any of thestroptions to be case-insensitive.