Fix NetCDF coordinate reads in topo_module: use varid instead of dimid#695
Open
mandli wants to merge 6 commits intoclawpack:masterfrom
Open
Fix NetCDF coordinate reads in topo_module: use varid instead of dimid#695mandli wants to merge 6 commits intoclawpack:masterfrom
mandli wants to merge 6 commits intoclawpack:masterfrom
Conversation
Member
Author
|
This now works for the GEBCO data I was testing on, but I want to change over all the NetCDF places I think this is happening while I am at it. |
Also added trim to var name checks for buffer safety
Member
Author
|
There are some changes to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
topo_module.f90retrieves coordinate data using:where
x_dim_id/y_dim_idare dimension IDs and not variable IDs. The NetCDF Fortran API requires variable ID fornf90_get_var.Because NetCDF IDs are integers, this sometimes silently works when a dimid numerically matches a varid, but fails for valid CF files (e.g., GEBCO NetCDF4) with:
This PR simply switches to the proper variable query
and checks those coordinates.
Also adds a small fix for nearest-index searches with