Dedupilcate language selector for I-Notes create new epub (Close #800) #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #800 originated from the source (video id=
31c8ebb3-0708-440c-b2a3-603c307c6ec8) having multiple english sources and a single one for all other languages.We get the list from
source.transcriptionsinEPubListController.getLanguages(). Getting this list of seemingly duplicate languages is correct but we shouldn't display them differently so I used a Set to dedup the values for the selector. If it makes sense for any other components we can move the logic up if needed too