Use GitHub Actions #78
Conversation
using the latest Hugo v0.142.0
| steps: | ||
| - name: Deploy to GitHub Pages | ||
| id: deployment | ||
| uses: actions/deploy-pages@v4 |
There was a problem hiding this comment.
AFAIK we don't use GitHub pages for clash-lang.io.
There was a problem hiding this comment.
What are you trying to achieve? Was anything wrong with the Netlify integration?
There was nothing wrong with it in particular. I just found the GitHub Actions Integration much cleaner in terms of maintainability (the travis.yml looks a bit hacked together, to be honest). It worked out of the box for clash-formal.org, even with the latest hugo, so I thought it might be desirable to use it here as well.
Note that this template is completely provided as is by GitHub Pages. The only thing I changed was the version of hugo.
AFAIK we don't use GitHub pages for clash-lang.io.
I have no clue what we use. It's hard to deduce that from the content of the repo.
There was a problem hiding this comment.
Oh gotcha, the Travis stuff is unused. We're just using Netlify integration.
|
@kleinreact I propose just deleting |
|
@martijnbastiaan How about the Hugo update? Could we ship that one with Netlify as well? I don't have any insights how their integration works. |
|
I can only change the Node version and Ubuntu version in their settings interface. I'll bump it and then it should build with a newer Hugo (the one paired with Ubuntu 24.04?). |
|
In any case: I do think it makes more sense to build with GHA as it gives us tighter control over how we build. However, we do get some very nice features like previews at the moment. |
|
Turns out I don't know what determines the Hugo version.. Have a look: https://app.netlify.com/sites/gifted-fermi-ffd5ae/deploys/67a5cc1580a0580008844f96. It still uses an old Hugo. |
Just brainstorming here. We could create an artifact with the built website in GitHub Actions, and then have a script in that same action that posts a reply on the open PR with a link to the artifact. That way you don't have to click through a bunch of pages to get to the artifact but it would be neatly accessible from the PR. I don't know if this would work, it's just a thought. |
Does anybody use these previews at the moment? I just use a local hugo to check everything, which comes with the least friction in terms of interaction.
👍 I also consider it to be easier to integrate with other tools and APIs. |
Yes! |
The PR switches the website build and deployment from Travis to Github Actions using the default template provided by GitHub for deployment of Hugo websites.
The PR also updates to the latest Hugo v0.142.0 introducing the required changes to avoid deprecation warnings.
We already use the same process successfully for https://github.com/clash-lang/clash-formal.org.