Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sqlalchemy 1.4/2.0 #40

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Fix sqlalchemy 1.4/2.0 #40

merged 6 commits into from
Nov 25, 2024

Conversation

mixmind
Copy link
Contributor

@mixmind mixmind commented Oct 11, 2024

No description provided.

@mixmind mixmind force-pushed the fix/reuvens/sqlalchemy-14-fixes branch 2 times, most recently from c31441a to f811ba7 Compare October 11, 2024 18:15
@mixmind mixmind force-pushed the fix/reuvens/sqlalchemy-14-fixes branch 10 times, most recently from 19c79da to 453f8ae Compare November 7, 2024 15:41
@mixmind mixmind force-pushed the fix/reuvens/sqlalchemy-14-fixes branch from 453f8ae to ae7538a Compare November 7, 2024 17:16
@mixmind mixmind changed the title Fix sqlalchemy 1.4 and bump environs Fix sqlalchemy 1.4 Nov 7, 2024
@mixmind mixmind changed the title Fix sqlalchemy 1.4 Fix sqlalchemy 1.4/2.0 Nov 7, 2024
@@ -15,6 +14,7 @@
engine = create_engine(DB_URI)
SessionMaker = sessionmaker(bind=engine)

# TODO: Add proper typing when we drop support for sqlalchemy < 2.0 # pylint: disable=fixme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit TODOs

@mixmind mixmind force-pushed the fix/reuvens/sqlalchemy-14-fixes branch 9 times, most recently from 6d9bfc7 to 925f53b Compare November 25, 2024 12:37
bump aiohttp
pin setuptools
@mixmind mixmind force-pushed the fix/reuvens/sqlalchemy-14-fixes branch from 925f53b to b070ea0 Compare November 25, 2024 12:52
@mixmind mixmind merged commit a45fed0 into main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants