provide an example of buffered metrics #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssube
force-pushed
the
feature/buffer-metrics
branch
from
b760e3a
to
dc37b80
Compare
lrojas94
reviewed
Dec 5, 2023
| @@ -27,7 +27,7 @@ export function createMetricProcessor({ | |||
| async update() { | |||
| if (!clickhouse) return; | |||
| const [lastUpdate, setLastUpdate] = await getJobDate(`metric:${name.toLowerCase()}`); | |||
| const ctx = { db: dbWrite, ch: clickhouse, lastUpdate }; | |||
| const ctx = { db: dbRead, dbWrite, ch: clickhouse, lastUpdate }; | |||
There was a problem hiding this comment.
By doing this you'll globally break all other metrics as they rely on db being dbWrite 😬 this can be done, but you must apply this fix to everything.
There was a problem hiding this comment.
Good point. I was trying to avoid the larger/noisier refactor to dbRead, to keep this example minimal, but that will need to be updated for this to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing metrics, run queries against the read replica and buffer the results in the JS worker before writing them back.
This does not address
recreateRankTable.