Only set crm-public on profiles when public

[mattwire]

Overview

See: https://chat.civicrm.org/civicrm/pl/kmhhwbftnbd55mji1nz3t73rjw

Only add crm-public class if public.

Before

Always added to profiles

After

Only added if public (following pattern used in other templates)

Technical Details

Comments

@vingle I didn't test this change. But looks like it's probably the right approach.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[vingle]

Thanks. This looks like it should, but doesn't seem to fix the problem…

(to recreate, go to Contacts > New Activity and under 'With Contact' select New individual - the profile is wrapped with .crm-public)

[mattwire]

ok, well it seems urlIsPublic was meaning that the URL could be accessible publicly when what we really want is to check if we are accessing via the frontend. I've updated the PR. Not sure if there are any other implications of this change.

[vingle]

That fixes it!

Not sure if there are implications either. Had a check of http://core-32499-r18i.test-1.civicrm.org:8003/civicrm/contribute/transact?reset=1&id=1 - it still works, tho noticed it doesn't seem to have .crm-container.crm-public anywhere which I wasn't expecting, but that seems to be the case everywhere, ie not linked to this PR.

[mattwire]

That fixes it!

Not sure if there are implications either. Had a check of http://core-32499-r18i.test-1.civicrm.org:8003/civicrm/contribute/transact?reset=1&id=1 - it still works, tho noticed it doesn't seem to have .crm-container.crm-public anywhere which I wasn't expecting, but that seems to be the case everywhere, ie not linked to this PR.

I suppose the contribution page is assumed to always be frontend and so didn't need crm-public - I guess event registration pages behave the same?

[vingle]

I guess event registration pages behave the same?

True.

Edit: actually it varies a bit by CMS. On Joomla contribution pages do have the class, ie a wrapper like this:

<div id="crm-container" class="crm-container crm-public" lang="en" xml:lang="en">
   <div id="crm-content">