Import entityreference fields; generalize loading options on large option list fields on import #32401
+45
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
| // @todo - make this generic - for fields where getOptions doesn't fetch | ||
| // getOptions does not retrieve these fields with high potential results | ||
| if ($fieldName === 'event_id') { | ||
| // @todo - it would be faster in most cases to retrieve and cache all potential results. |
There was a problem hiding this comment.
It might be worth mentioning that the 'most' here has been determined in the past to exclude event_id on sites with lots of events
There was a problem hiding this comment.
It would be nice if we used metadata like "prefetch" instead of hard-coding that sort of thing.
MegaphoneJon
force-pushed
the
import-entityref-custom-fields
branch
from
a4bc009 to
6ade9bb
Compare
…or pseudoconstants with large data sets
MegaphoneJon
force-pushed
the
import-entityref-custom-fields
branch
from
6ade9bb to
ae9aa1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Note: #32400 must be merged first.
https://lab.civicrm.org/dev/core/-/issues/5799
It's not currently possible to import an EntityReference custom field by anything but an ID.
Before
Import organization name "Default Organization" to an organization EntityReference custom field fails.
After
Succeeds.
Comments
I let the scope creep and tried to implement the TODO of making the code for event ID and campaign ID generic. This led me to the bug fixed in #32400.
As a side effect, this gives a better error message when a field has an invalid value. I mentioned one example on the lab.c.o ticket but there's another one in the test I changed.