Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

Dockless react #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mateoclarke
Copy link
Contributor

No description provided.

@mateoclarke
Copy link
Contributor Author

@dontehightower, I know we chatted a bit on Slack via DM but wanted to summarize some of my feedback for anyone else watching like @johnclary:

The components look good! You got pretty far, at least with the base component templates. Still lots of work to do around the interactions, downloading data, and drawing MapboxGL features. And really cool that you threw in some tests. I'm seeing how refactoring towards React is going a pretty big effort.

It looks like you separated all the code into two directories and tried to copy paste over code to the React side. This will break the way Netlify looks for the build script at the root level so we can't merge in the new code this way. Maybe if you reorganized the code so the react dir was a sub directory of the jquery dir and leave that like it was at root? That way we could keep on refactoring in the subdir without being worried about breaking production code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants