Fix downgrade and following upgrade #7950
Conversation
|
@microsoft-github-policy-service agree |
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (80.76%) is below the target coverage (87.50%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #7950 +/- ##
==========================================
- Coverage 89.19% 80.76% -8.43%
==========================================
Files 283 283
Lines 61053 60868 -185
Branches 7625 7566 -59
==========================================
- Hits 54456 49163 -5293
- Misses 4412 8918 +4506
- Partials 2185 2787 +602 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@manaldush - you probably need to run make reindent to get the style checks passing.
Do you think could this introduce a perf regression? From my perspective, that "might" the case but also not quite sure ..
So, we should definitely do performance testing for this PR, but it could also wait until the release testing kicks in.
What do you think?
@alperkocatas, could you test this on your Mac once you have some time for it?
|
@onurctirtir re-run |
Thank you! Let's wait for others to chime in a bit. |
|
Oh, seems some of the regression tests are failing. Could you look to see why it's the case @manaldush? From https://github.com/citusdata/citus/actions/runs/14310120419?pr=7950, as an example, multi_cluster_management is failing. You can run this test locally as below (we of course need to fix others too): cd src/test/regress/
# one time setup begins
pip install pipenv
pipenv --rm
pipenv install
# one time setup ends
pipenv shell
citus_tests/run_test.py multi_cluster_management --use-base-schedule --use-whole-schedule-lineAlso see src/test/regress/README.md. |
@onurctirtir, found problem and fixed |
In case of citus downgrade and further upgrade citus crash with core dump.
The reason is that citus hardcoded number of columns in pg_dist_partition table,
but in case of downgrade and following update table can have more columns, and
some of then can be marked as dropped.
Patch suggest decision for this problem with using tupleDescriptor->nattrs(postgres internal approach).
Fixes #7933.