tweak(five): edit carcols aka sirensettings value to allow for 16bit #3273
+4,134
−4,127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Adjust from 8-bit to 16-bit carcols/sirensettings values to go beyond 255. Fixing servers that have reached more than 255 emergency vehicles in regards to conflicting carcols ID values.
This value is located in carcols.meta under as well as carvariations.meta and is currently an 8-bit value thus limiting people to only 255 unique values.
...
How is this PR achieving the goal
...
This PR applies to the following area(s)
FiveM, Server, C#
...
Successfully tested on
Not yet tested.
Game builds: ..
Platforms: Windows, Linux
Checklist
Fixes issues
Allow for more than 255 emergency vehicles with unique siren - emergency light patterns.
Basic attempt [with little knowledge, apologies] to fix: #2612