Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(five): edit carcols aka sirensettings value to allow for 16bit #3273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Legacy-TacticalGamingInteractive

Goal of this PR

Adjust from 8-bit to 16-bit carcols/sirensettings values to go beyond 255. Fixing servers that have reached more than 255 emergency vehicles in regards to conflicting carcols ID values.

This value is located in carcols.meta under as well as carvariations.meta and is currently an 8-bit value thus limiting people to only 255 unique values.

...

How is this PR achieving the goal

  • Attempt to allow reading of not only single bit values but 16-bit values as well.
  • Read values properly.
    ...

This PR applies to the following area(s)

FiveM, Server, C#
...

Successfully tested on

Not yet tested.

Game builds: ..

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Allow for more than 255 emergency vehicles with unique siren - emergency light patterns.

Basic attempt [with little knowledge, apologies] to fix: #2612

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Mar 22, 2025
@Legacy-TacticalGamingInteractive Legacy-TacticalGamingInteractive marked this pull request as ready for review March 22, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
1 participant