feat(scripting/v8): implement vector classes #3262
Draft
+92
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Improve compatibility of vector types across scripting runtimes.
Note this is a technically breaking change to some scripts, as a few developers have opted to depend on undefined behaviour (i.e. implementation details).
How is this PR achieving the goal
Implements simple vector classes which can be correctly encoded and decoded with msgpack.
This PR applies to the following area(s)
ScRT: JS
Successfully tested on
Game builds: 3407
Platforms: Windows
Checklist
Fixes issues
Supersedes #2946.