-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(citizen-devtools): added GET_RESOURCE_MONITOR_DATA #3221
base: master
Are you sure you want to change the base?
feat(citizen-devtools): added GET_RESOURCE_MONITOR_DATA #3221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add proper structure to the documentation?
Thank you for this contribution. Could you also add client side version as well? |
I'm generally curious on why expose like this vs adding more Prometheus endpoints |
Also thought about that, but I don't have much knowledge of the codebase and how it should be implemented |
But in this case how should we provide client side data? |
Maybe add the native only on client-side and add another Prometheus endpoint on the server-side, I think that would also reduce the performance cost of the implementation to redirect the data from the native to Grafana / Prometheus / etc. |
I don't think that the client side should be included in this PR at all, there should be some proper way for the client to send the server performance metrics if that is wanted, otherwise we'll end up with a weird "everyone makes there own, and there's no nice/standardized way to do it" and it will be a big mess. IMO, The server should add more endpoints (i.e. |
Goal of this PR
Providing the ability to get data from the resource monitor to visualize it in grafana or something else
How is this PR achieving the goal
Added the
GET_RESOURCE_MONITOR_DATA
nativeThis PR applies to the following area(s)
Server, Natives
Successfully tested on
Platforms: Windows
Checklist
Fixes issues