Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(loading-screens-five): option to hide busy spinner in loading screen #3198

Merged
merged 1 commit into from
Mar 24, 2025
Merged

feat(loading-screens-five): option to hide busy spinner in loading screen #3198

merged 1 commit into from
Mar 24, 2025
+5 −1

Conversation

tens0rfl0w
Copy link
Contributor

Goal of this PR

Adding an option to allow hiding the busy spinner in the loading screen:
image

How is this PR achieving the goal

Added a fxmanifest entry called loadscreen_hide_busyspinner to allow hiding this.

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 3407

Platforms: Windows (Client)

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

/

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 26, 2025
@prikolium-cfx prikolium-cfx added status:needs planning Hard issues that take time as there's no 'one' obvious way. manual-review PRs that need manual review and work before merging. needs manual verification PRs that need manual verification by testing the change locally and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Mar 6, 2025
@prikolium-cfx prikolium-cfx self-requested a review March 6, 2025 10:28
@IllInuz
Copy link

IllInuz commented Mar 13, 2025

Oh this is one of the best PR's i've seen so far.

@prikolium-cfx
Copy link
Collaborator

prikolium-cfx commented Mar 21, 2025 •
edited
Loading

Thank you for the contribution. Could you please move this option to ConVar instead? We want to prevent possible issues when many resources overriding same value.

@tens0rfl0w tens0rfl0w force-pushed the feat/loading-screens-five/hide-busyspinner-option branch from 71c56e6 to 4851f83 Compare March 21, 2025 15:52
@tens0rfl0w
Copy link
Contributor Author

Could you please move this option to ConVar instead?

Done and tested!

@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed status:needs planning Hard issues that take time as there's no 'one' obvious way. manual-review PRs that need manual review and work before merging. needs manual verification PRs that need manual verification by testing the change locally labels Mar 21, 2025
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Mar 21, 2025
@Legacy-TacticalGamingInteractive
Copy link

ouu! very nice! was just wondering about this two days ago and viola aha

@prikolium-cfx prikolium-cfx merged commit 8f27cb7 into citizenfx:master Mar 24, 2025
6 checks passed
@tens0rfl0w tens0rfl0w mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prikolium-cfx prikolium-cfx prikolium-cfx approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR is enqueued for merging triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tens0rfl0w @IllInuz @prikolium-cfx @Legacy-TacticalGamingInteractive