Specify all variables in the basic_usage example as non-nullable
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #221 we made all of the variables in the example module non-nullable but did not do the same to the `basic_usage` example. Since it uses variables beyond the requirements of the example module it makes sense to also specify the example's variables as non-nullable.
mcdonnnj
added
bug
jsf9k
approved these changes
Nov 13, 2024
dav3r
approved these changes
Nov 13, 2024
mcdonnnj
added
the
kraken 🐙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request makes the variables in the
basic_usageexample root module non-nullable.💭 Motivation and context
This mirrors the change made in #221. If the variables in the
basic_usageexample were only those required by the example module this might not make sense, but since some variables are used separately I believe it makes sense to also make the example's variables non-nullable.🧪 Testing
Automated tests pass.
✅ Pre-approval checklist