Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting virtualenv installation successfully #244

Closed
wants to merge 1 commit into from

Conversation

arcsector
Copy link
Contributor

Detecting virtualenv installation successfully

🗣 Description

Fixing #243

💭 Motivation and context

See #243 for context

🧪 Testing

Tested using pyenv in WSL2 without a pyenv-virtualenv binary in immediate path, despite having it installed properly and pyenv virtualenvs command working fine

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@mcdonnnj
Copy link
Member

@arcsector The lack of Linux compatibility with that script is a long-standing, undocumented issue that is nice to see resolved. However, would you please re-create this pull request in cisagov/skeleton-generic? We use a repository inheritance system through our Lineage process and the ultimate "source of truth" for that script is in the repository I mentioned.

@arcsector
Copy link
Contributor Author

Done - I'll close this PR since it sounds like this will be propgated from upstream.

@arcsector arcsector closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants