Run packer fmt on directories instead of files
#56
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that you can run `packer fmt` on a path and it will check any applicable files if that path is a directory. It makes sense to use that functionality in the packer_fmt hook instead of running it against each individual file.
mcdonnnj
added
the
improvement
mcdonnnj
changed the title
packer fmt on paths instead of filespacker fmt on directories instead of files
dv4harr10
approved these changes
Dec 17, 2024
jsf9k
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the
packer_fmthook to run against unique directory paths instead of individual files.💭 Motivation and context
So it turns out that when you provide a directory to
packer fmtit will format any applicable file within that directory. This is, in my opinion, a cleaner approach to leverage instead of running against each individual file.🧪 Testing
Automated tests pass. I verified this works in a testing template.
✅ Pre-approval checklist