Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Packer don't reset stty properly #55

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

smutel
Copy link

@smutel smutel commented Dec 17, 2024

🗣 Description

After the execution of pre-commit, my shell is completely blocked.
I need to type the command reset to re-init it.
The goal of this PR is to resolve this issue.

💭 Motivation and context

Workaround for bug in packer: hashicorp/packer#11416

🧪 Testing

Test it with command:

$ pre-commit try-repo /tmp/pre-commit-packer packer_fmt --verbose --all-files

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k
Copy link
Member

jsf9k commented Dec 17, 2024

FWIW, I am also seeing this behavior.

@mcdonnnj
Copy link
Member

I haven't cut a new release yet, but can you verify that it still occurs as of #54? Since the command is running in a daemonized fork I'm curious if the behavior is still exhibited.

@smutel
Copy link
Author

smutel commented Dec 18, 2024

Yes, same behavior. I rebased by branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants