Pass arguments to Packer #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just pulls Packer arguments out to separate them from the files that are passed in by pre-commit. Note that this is a minimal effort implementation so arguments with values should use the `-arg=value` form. This also breaks the `-check` argument out into the overwritable `args` value for the hook.
This just pulls Packer arguments out to separate them from the files that are passed in by pre-commit. Note that this is a minimal effort implementation so arguments with values should use the `-arg=value` form.
mcdonnnj
added
breaking change
dv4harr10
approved these changes
Sep 10, 2024
jsf9k
approved these changes
Sep 10, 2024
6 tasks
11 tasks
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds naive argument pass-through for the
packer_fmtandpacker_validatehooks.Warning
This naive approach will not differentiate file paths that begin with a
-from arguments. However, when testing a workaround I found that a lot of hooks also do not like paths that begin with a-.💭 Motivation and context
This will allow consumers of the hook to pass options through to the underlying Packer calls. It will also allow one to override the current default behavior of the
packer_fmthook to only check and not write changes to files. Note that this effectively replaces #13 and #25 by allowing a consumer of the hook to set their own arguments.🧪 Testing
Automated tests pass. This worked as expected when I tested it locally.
✅ Pre-approval checklist