-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3011 - The "Request growth" report is missing data - [backup] #3271
base: main
Are you sure you want to change the base?
Conversation
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
# Generate fake data for first_submitted_date and last_submitted_date | ||
# First generate a random date set to be later than 2020 (or something) | ||
# (if we just use fake.date() we might get years like 1970 or earlier) | ||
earliest_date_allowed = datetime(2020, 1, 1).date() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore you had to pick 2020.... shakes head
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
🥳 Successfully deployed to developer sandbox nl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🥳 Successfully deployed to developer sandbox nl. |
Ticket 3011
Resolves #3011
Changes
Context for reviewers
Setup
Code Review Verification Steps
Go to /admin/analytics. Pull a large date range for"Request growth" report. Verify that:
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots