(getgov-za) Ticket #2047: Force new users to finish setting up profile #2168

zandercymatics · 2024-05-14T19:34:10Z

Ticket

Resolves #2047

Changes

Adds a finish profile setup page, as well as middleware logic to contain that. Interacts with the your profile page.

Context for reviewers

Note: This ticket requires #1807. The content of that PR is merged into this one.
This PR adds a "Finish profile setup" page for new users under two circumstances:

When the incoming user is a "new" user (i.e. their user account was just created in our DB) so they can review their information. This is because OIDC doesn't give us all the information we need.
When an existing user is missing information such as their title or phone number

In addition, this PR is intended to redirect the user to their original, desired destination. This means that if the user clicks the "start your domain request" button on get.gov, they will be redirect to the start a new domain request page. Otherwise, they'll be redirected to home. For now, just domain request and home are supported as design would want custom content for other pages if it becomes something we want to consider.

It is toggleable with the profile_feature waffle flag in Django Admin. This is off by default so set it to everyone.

Setup

Login as a super user, and navigate to /admin
Go to the users table
Find your user record in the table, and edit it. Blank out a field. I suggest the title field, but you can test others.
Go to the waffle flag table and click the "profile_feature" record
Modify the waffle flag such that the "everyone" field is set to yes
At this point, you should be redirect to the setup page. Try triggering error conditions, adding field values, removing them. Etc.
After you save, click the "Back to manage your domains" button
Go to /admin
While logged in as a superuser, click the users table and click the corresponding record for your analyst account
Blank out a field as before
Open a new window (or browser) that is not logged into login.gov
Navigate to https://getgov-za.app.cloud.gov/request/ (or if your testing locally, localhost:8080/request)
Login with your analyst account
Save as normal. At the end, you should be redirected to the domain request page. You should no longer see the "Back to manage your domains" button and instead a continue button next to the save button

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Added at least 2 developers as PR reviewers (only 1 will need to approve)
Messaged on Slack or in standup to notify the team that a PR is ready for review
Changes to “how we do things” are documented in READMEs and or onboarding guide
If any model was updated to modify/add/delete columns, makemigrations was ran and the associated migrations file has been commited.

Ensured code standards are met (Original Developer)

All new functions and methods are commented using plain language
Did dependency updates in Pipfile also get changed in requirements.txt?
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Add at least 1 designer as PR reviewer

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Reviewed this code and left comments
Checked that all code is adequately covered by tests
Made it clear which comments need to be addressed before this work is merged
If any model was updated to modify/add/delete columns, makemigrations was ran and the associated migrations file has been commited.

Ensured code standards are met (Code reviewer)

All new functions and methods are commented using plain language
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values
(Rarely needed) Did dependency updates in Pipfile also get changed in requirements.txt?

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links
Tried to break the intended flow

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user