Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CrackMapExec and add NetExec #182

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 18, 2025

🗣 Description

This pull request removes the installation of Porchetta-Industries/CrackMapExec and installs Pennyw0rth/NetExec.

💭 Motivation and context

I noticed that Porchetta-Industries/CrackMapExec no longer built under Python 3.13 on Kali Linux, and upon further investigation saw that the repo was archived as of December 2023. @m1j09830 informed me that Pennyw0rth/NetExec has superseded Porchetta-Industries/CrackMapExec, the former offers all the capabilities of the latter, and that is the tool the assessors are using now. They have been installing it themselves, so this change should make their lives a little simpler.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Bump version.
  • Build and test a pre-release of this AMI.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

I noticed that CrackMapExec is no longer supported, nor can it be
built under Python 3.13.  @m1j09830 informed me that CrackMapExec has
been superseded by NetExec, so the former no longer need be installed.
NetExec is the successor to CrackMapExec, which was removed in the
previous commit.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number ansible Pull requests that update Ansible code labels Feb 18, 2025
@jsf9k jsf9k self-assigned this Feb 18, 2025
jsf9k added a commit to cisagov/ansible-role-assessment-tool that referenced this pull request Feb 18, 2025
Porchetta-Industries/CrackMapExec is no longer being installed in our
Kali AMI as of cisagov/kali-packer#182, so we no longer have an
example of a Rust installation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Pull requests that update Ansible code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant