Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hanging references #121

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Remove hanging references #121

merged 2 commits into from
Mar 11, 2025

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Mar 11, 2025 •
edited
Loading

🗣 Description

This pull request fixes references to docker-compose.yml and removes the reference to a removed build argument.

💭 Motivation and context

These changes were missed in #119.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation labels Mar 11, 2025
@mcdonnnj mcdonnnj requested a review from a team March 11, 2025 14:18
@mcdonnnj mcdonnnj self-assigned this Mar 11, 2025
@mcdonnnj mcdonnnj requested review from dav3r and jsf9k as code owners March 11, 2025 14:18
@mcdonnnj mcdonnnj merged commit 9f2cf4d into develop Mar 11, 2025
32 of 35 checks passed
@mcdonnnj mcdonnnj deleted the bugfix/fix_hanging_references branch March 11, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

Assignees

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @dav3r @dv4harr10