Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #84

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Mar 13, 2025

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-ansible-role-with-test-user.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone [email protected]:cisagov/ansible-role-cyhy-core.git ansible-role-cyhy-core
    cd ansible-role-cyhy-core
    git remote add skeleton https://github.com/cisagov/skeleton-ansible-role-with-test-user.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add molecule/default/converge.yml 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All new and existing tests pass.

Note

You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

jsf9k added 2 commits March 10, 2025 23:00
Now that we have an SSM Parameter Store parameter containing the name
of the third-party bucket it is no longer necessary to pass the
third-party bucket name via an environment variable.
…cket-parameter

Remove example code that is no longer necessary
jsf9k added 2 commits March 13, 2025 22:08
…the 3rd-party bucket

These will be useful for future Ansible role developers who use this
skeleton repository.
Add comments suggesting what needs to be done for roles that require the third-party bucket
@jsf9k jsf9k force-pushed the lineage/skeleton branch from eb42ac8 to d509ab4 Compare March 14, 2025 18:43
@jsf9k jsf9k marked this pull request as ready for review March 14, 2025 19:18
@jsf9k jsf9k requested review from dav3r and felddy as code owners March 14, 2025 19:18
@jsf9k jsf9k requested review from jsf9k and mcdonnnj as code owners March 14, 2025 19:18
@jsf9k jsf9k enabled auto-merge March 14, 2025 19:18
@jsf9k jsf9k requested a review from a team March 14, 2025 19:18
@jsf9k jsf9k merged commit 1b2436b into develop Mar 20, 2025
16 of 17 checks passed
@jsf9k jsf9k deleted the lineage/skeleton branch March 20, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code upstream update This issue or pull request pulls in upstream updates
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants