Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with crashing when accessing user registration as Global View (CRASM-2293) #845

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

RKohler21
Copy link
Collaborator

@RKohler21 RKohler21 commented Apr 7, 2025

…iew or region admin

🗣 Description

Fixed issue with crashing when accessing user registration as globalView

💭 Motivation and context

This change is necessary as it resolves an issue in which, as a Global View, when selecting user registration the user would be logged out of the application. Closes CRASM-2293

🧪 Testing

For testing I swapped between the Regional Admin, GlobalView, and Global Admin user types while accessing the user registration page. All of which seem to react normally after the fix.

📷 Screenshots (if appropriate)

Screenshot 2025-04-07 at 2 33 24 PM

-->

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@RKohler21 RKohler21 added the bug This issue or pull request addresses broken functionality label Apr 7, 2025
@RKohler21 RKohler21 self-assigned this Apr 7, 2025
@RKohler21 RKohler21 changed the title Fixed issue with crashing when accessing user registration as globalView Fixed issue with crashing when accessing user registration as globalView(CRASM-2293) Apr 7, 2025
@RKohler21 RKohler21 changed the title Fixed issue with crashing when accessing user registration as globalView(CRASM-2293) Fixed issue with crashing when accessing user registration as Global View(CRASM-2293) Apr 7, 2025
@RKohler21 RKohler21 changed the title Fixed issue with crashing when accessing user registration as Global View(CRASM-2293) Fixed issue with crashing when accessing user registration as Global View (CRASM-2293) Apr 7, 2025
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in a group meeting

@rapidray12 rapidray12 merged commit 49af754 into develop Apr 9, 2025
14 of 15 checks passed
@rapidray12 rapidray12 deleted the RK_registrationMenu_logout_fix branch April 9, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants