Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csv export fields and names #843

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Apr 7, 2025

🗣 Description

Update csv export fields and names

💭 Motivation and context

CSV exports from tables were showing the action fields instead of hiding them. They csv also all had a generic name so they are now named based on the type of data being exported. CRASM 1101

Due to similarity in tasks, also removed the print button from the export since printing from the csv is a better option.
CRASM 2339

🧪 Testing

Click on the export button whenever available and see that there is no empty "edit" or "delete" field for example.

📷 Screenshots

Example of what an export will look like now

image

Removed print option

image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Apr 7, 2025
@ameliav ameliav added the bug This issue or pull request addresses broken functionality label Apr 7, 2025
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in a group meeting

@rapidray12 rapidray12 merged commit ee5c24e into develop Apr 9, 2025
13 of 16 checks passed
@rapidray12 rapidray12 deleted the remove-blank-fields-csv-crasm-1101 branch April 9, 2025 14:51
Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants