Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRASM-2286:Add Regression Test Workflow with Dockerized Playwright in AWS #824

Merged
merged 31 commits into from
Apr 1, 2025
Merged

CRASM-2286:Add Regression Test Workflow with Dockerized Playwright in AWS #824

merged 31 commits into from
Apr 1, 2025

Conversation

JCantu248
Copy link
Collaborator

🗣 Description

This PR will add a workflow for Playwright to push Dockerized Playwright to ECR, deploy, run Playwright, and store artifacts in S3 bucket.

💭 Motivation and context

This is to help facilitate frontend regression testing on a deployed environment.

🧪 Testing

Code was validated in pre-commit and reviewed through Copilot and GPT.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

JCantu248 and others added 23 commits January 22, 2025 09:06
@JCantu248
Add new integration test, integration.yml
0d15da6
@jyang2139
vulnerabilities tests
7b7bab4
@jyang2139
fixed tests
21cb495
@jyang2139
put test update
fb459ed
@jyang2139
test
6fe3611
@JCantu248
Add method to return domain, vulnerability uids for other test cases.
41a384c
@jyang2139
updated test for new methods
15c37a7
@JCantu248
Change get_domains, get_vulnerabilities to return entire object, not …
f6ab796 
…just id. Then use that to randomly select an id or search parameter for tests.
@jyang2139
updates to id method
76d2a92
@jyang2139
fixing environment variable
ebd4add
@JCantu248
Merge pull request #774 from cisagov/jy_integration_tests
a083545 
Vulnerabilities integration tests
@JCantu248
Code cleanup for test_vulnerabilities.py.
3df9356
@JCantu248
Testing integration workflow on push.
dc09d63
@JCantu248
Add requirements.txt, changes to test_domains.
bfd732a
@aloftus23
Update integration.yml
17db7c3
@JCantu248
Reverting integration.yml to only on deployment status.
c8454f6
@JCantu248
Merge branch 'JD_integration_tests' of github.com:cisagov/XFD into JD…
6ba373a 
…_Integration_tests
@JCantu248
Merge branch 'develop' into JD_integration_tests
45b81c9
@JCantu248
Merge branch 'develop' of github.com:cisagov/XFD into JD_integration_…
6012cd3 
…tests
@JCantu248
Merge branch 'develop' of github.com:cisagov/XFD into develop
abb21c2
@JCantu248
Merge branch 'develop' of github.com:cisagov/XFD into develop
8e8f3eb
@JCantu248
Add regression.yml for Dockerized Playwright actions, modifications t…
2a42ebd 
…o playwright.tf
@JCantu248
Remove integration tests that were accidentally included in this branch
d1459d3
@JCantu248 JCantu248 added github_actions Pull requests that update GitHub Actions code docker Pull requests that update Docker code labels Mar 21, 2025
@JCantu248 JCantu248 self-assigned this Mar 21, 2025
@JCantu248 JCantu248 marked this pull request as ready for review March 27, 2025 16:24
@JCantu248 JCantu248 marked this pull request as draft March 27, 2025 16:25
@JCantu248 JCantu248 marked this pull request as ready for review March 27, 2025 19:18
rapidray12
rapidray12 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review in the BrownBAG

cduhn17
cduhn17 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straight forward

@rapidray12 rapidray12 merged commit 0c46a38 into develop Apr 1, 2025
13 checks passed
@rapidray12 rapidray12 deleted the CRASM_2286_Github_Actions_Dockerized_Playwright branch April 1, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduhn17 cduhn17 cduhn17 approved these changes

@rapidray12 rapidray12 rapidray12 approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jsf9k jsf9k Awaiting requested review from jsf9k jsf9k is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@JCantu248 JCantu248

Labels
docker Pull requests that update Docker code github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JCantu248 @cduhn17 @rapidray12 @jyang2139 @aloftus23