Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV Not Displayed on User Import #256

Merged
merged 1 commit into from
May 21, 2024

Conversation

chrtorres
Copy link
Collaborator

@chrtorres chrtorres commented May 16, 2024

πŸ—£ Description

  • Fixed user CSV import not displaying on UI
  • Added delete file function to remove unwanted CSV

πŸ’­ Motivation and context

Previously, users were able to select a CSV file to upload but no prompt or indication was provided to notify the user of the applied changes. In this fix, a selected CSV file will be displayed on the dashboard, accompanied by a delete button should you choose to change files. Once a user is satisfied with the selected file, an "Upload CSV" button has been added to confirm the changes being added to the database.

This closes issue #40

πŸ“· Screenshots (if appropriate)

Before Fix:
image

After Fix:
Screenshot 2024-05-16 at 10 08 40β€―AM

Screenshot 2024-05-16 at 10 21 51β€―AM

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

@chrtorres chrtorres linked an issue May 16, 2024 that may be closed by this pull request
@chrtorres chrtorres changed the title Fix CSV Not Displayed on User ImportI; Fix CSV Not Displayed on User Import May 16, 2024
@chrtorres chrtorres self-assigned this May 16, 2024
@chrtorres chrtorres marked this pull request as ready for review May 16, 2024 14:56
@chrtorres chrtorres added frontend bug This issue or pull request addresses broken functionality labels May 16, 2024
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 97d35ff into develop May 21, 2024
14 of 15 checks passed
@schmelz21 schmelz21 deleted the 40-user-csv-import-not-functioning-as-expected branch May 21, 2024 15:48
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IAH ILF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User CSV Import Not Functioning as Expected
5 participants