-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Front Page Dashboard to include High Level Findings and Vuln Severities #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
ameliav
changed the title
Update depreciated import in TopVulnerableDomains.tsx
Update Front Page Dashboard and include VS metrics
May 9, 2024
create endpoint to pull all VS high level findings
remove commented out code and fix spacing
merge develop to capture post_scan model updates
Fix where we save the children
uncomment out worker
Add additional query functions to get more findings
add stats endpoints for High level findings
update stats return to include all severity types
ameliav
changed the title
Update Front Page Dashboard and include VS metrics
Update Front Page Dashboard to include High Level Findings and Vuln Severities
May 23, 2024
update let to const where the variable is not reassigned
β¦into 172-design-vs-graphs
ameliav
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
May 23, 2024 15:37
cduhn17
reviewed
May 23, 2024
remove unnecessary spaces
β¦into 172-design-vs-graphs
cduhn17
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See a minor comments.
cduhn17
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
schmelz21
approved these changes
May 23, 2024
cduhn17
added a commit
that referenced
this pull request
May 23, 2024
Revert "Merge pull request #237 from cisagov/172-design-vs-graphs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π£ Description
Visually appealing graphics to represent High Level Findings and Vuln Severities components in Crossfeed's front page dashboard
π Motivation and context
Enhance user experience and provide clear visual representation of crucial elements
π§ͺ Testing
Updated front page reflects the stakeholders' vision and the metrics coordinate with the org's data
π· Screenshots
Dashboard with test data and an org selected
Dashboard with test data and no org selected
β Pre-approval checklist
in code comments.
to reflect the changes in this PR.
β Pre-merge checklist
β Post-merge checklist