Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Front Page Dashboard to include High Level Findings and Vuln Severities #237

Merged
merged 37 commits into from
May 23, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented May 9, 2024

πŸ—£ Description

Visually appealing graphics to represent High Level Findings and Vuln Severities components in Crossfeed's front page dashboard

πŸ’­ Motivation and context

Enhance user experience and provide clear visual representation of crucial elements

πŸ§ͺ Testing

Updated front page reflects the stakeholders' vision and the metrics coordinate with the org's data

πŸ“· Screenshots

Dashboard with test data and an org selected
image

Dashboard with test data and no org selected
image

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

@ameliav ameliav linked an issue May 9, 2024 that may be closed by this pull request
2 tasks
@ameliav ameliav changed the title Update depreciated import in TopVulnerableDomains.tsx Update Front Page Dashboard and include VS metrics May 9, 2024
backend/src/api/stats.ts Fixed Show fixed Hide fixed
@ameliav ameliav changed the title Update Front Page Dashboard and include VS metrics Update Front Page Dashboard to include High Level Findings and Vuln Severities May 23, 2024
backend/src/api/stats.ts Fixed Show fixed Hide fixed
DJensen94 and others added 3 commits May 23, 2024 11:11
update let to const where the variable is not reassigned
@ameliav ameliav marked this pull request as ready for review May 23, 2024 15:37
backend/src/api/app.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a minor comments.

frontend/src/types/index.ts Show resolved Hide resolved
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit a8fc488 into develop May 23, 2024
19 of 23 checks passed
@cduhn17 cduhn17 deleted the 172-design-vs-graphs branch May 23, 2024 16:20
aloftus23 added a commit that referenced this pull request May 23, 2024
This reverts commit a8fc488, reversing
changes made to e8fe06d.
cduhn17 added a commit that referenced this pull request May 23, 2024
Revert "Merge pull request #237 from cisagov/172-design-vs-graphs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design VS Graph(s)
6 participants