Skip to content

Implement code for new CommonControls.3.2 #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

Implement code for new CommonControls.3.2 #646

merged 3 commits into from
Apr 24, 2025

Conversation

k-winters
Copy link
Contributor

🗣 Description

Implements Rego code for CommonControls.3.2

💭 Motivation and context

Closes #494

🧪 Testing

Tested using the SSO Profile settings in the GWS tenant.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@k-winters k-winters added enhancement Baseline Code Implementation A code change for baseline updates on the release branch during a baseline freeze. labels Mar 24, 2025
@k-winters k-winters added this to the Eel milestone Mar 24, 2025
@k-winters k-winters requested review from buidav and adhilto March 24, 2025 16:57
@k-winters k-winters self-assigned this Mar 24, 2025
@k-winters k-winters linked an issue Mar 24, 2025 that may be closed by this pull request
Implement code for new common controls 3.2 #494
Closed
1 task
buidav
buidav approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@buidav buidav force-pushed the 494-implement-code-for-new-common-controls-32 branch from 7c2ff1a to e053126 Compare April 24, 2025 01:51
@buidav buidav merged commit d7cec9d into main Apr 24, 2025
2 checks passed
@buidav buidav deleted the 494-implement-code-for-new-common-controls-32 branch April 24, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buidav buidav buidav approved these changes

@adhilto adhilto adhilto approved these changes

Assignees

@k-winters k-winters

Labels
Baseline Code Implementation A code change for baseline updates on the release branch during a baseline freeze. enhancement
Projects
None yet
Milestone
Eel
Development

Successfully merging this pull request may close these issues.

Implement code for new common controls 3.2
3 participants
@k-winters @buidav @adhilto