Indicate SubOU Hierarchy in Report for Sub+SubOUs #640
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This change makes it clear where SubOUs belong in the orgunit hierarchy when reporting baseline conformance. It was identified that subOUs within the hierarchy are currently only listed by their name (without the hierarchy). It's possible that two subOUs in different parts of the hierarchy may have the same name. This change adds to the displayed subOU name the path to subOUs below the 1st level of subOUs in the hierarchy. This change disambiguates cases where subOU names match, but also helps locate subOUs when the hierarchy is relatively deep.
Reporting of orgunits in the hierarchy is handled as follows:
The 1st level of orgunits below the top-level are identified only by name:
Any orgunit under these 1st level subOUs show the name followed by the path where they belong:
For the top-level orgunit, only the name is displayed:
Closes #623
🧪 Testing
Ran ScubaGoggles on
scubagws.org
tenant with baseline conformance failures in a variety of orgunits and sub-orgunits.Confirmed that the orgunits were displayed as described above, either without the hierarchy for the top-level orgunit and 1st level orgunits, or with the hierarchy for all other subOUs.
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist