Skip to content

Add Policy API Implementation of Common Controls 16.1 #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Add Policy API Implementation of Common Controls 16.1 #598

merged 1 commit into from
Mar 19, 2025

Conversation

rlxdev
Copy link
Contributor

@rlxdev rlxdev commented Feb 12, 2025 •
edited
Loading

🗣 Description

Re-implemented Common Controls 16.1 using Google's Policy API. Removed the log event implementation for this baseline, as well as the tests for that implementation.

Closes #597

🧪 Testing

Added tests for the new Policy API implementation. Tested also using the scubagws tenant.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev added the eel label Feb 12, 2025
@rlxdev rlxdev added this to the Eel milestone Feb 12, 2025
@rlxdev rlxdev self-assigned this Feb 12, 2025
@rlxdev rlxdev force-pushed the 506-cleanup-commoncontrols-rego branch 2 times, most recently from 642fbfe to 6e5bf53 Compare February 24, 2025 14:41
@rlxdev rlxdev force-pushed the 597-commoncontrols_16-1 branch from 3107873 to 6888083 Compare February 25, 2025 20:52
@rlxdev rlxdev changed the base branch from 506-cleanup-commoncontrols-rego to main February 27, 2025 14:50
@rlxdev rlxdev force-pushed the 597-commoncontrols_16-1 branch from 6888083 to 2f32dca Compare February 27, 2025 14:51
@rlxdev rlxdev linked an issue Feb 27, 2025 that may be closed by this pull request
Implement Common Controls 16.1 using Policy API #597
Closed
@rlxdev rlxdev marked this pull request as ready for review February 27, 2025 14:53
@adhilto adhilto self-requested a review February 27, 2025 15:35
@adhilto
Copy link
Collaborator

adhilto commented Feb 28, 2025

@rlxdev could you assign a second reviewer to this PR?

@snarve snarve merged commit b10aa45 into main Mar 19, 2025
8 of 11 checks passed
@snarve snarve deleted the 597-commoncontrols_16-1 branch March 19, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

@snarve snarve snarve approved these changes

@mitchelbaker-cisa mitchelbaker-cisa Awaiting requested review from mitchelbaker-cisa

Assignees

@rlxdev rlxdev

Labels
eel
Projects
None yet
Milestone
Eel
Development

Successfully merging this pull request may close these issues.

Implement Common Controls 16.1 using Policy API
3 participants
@rlxdev @adhilto @snarve