chore: Remove deprecated FD-tracking actions#4700
Draft
ariosmon wants to merge 1 commit intocilium:mainfrom
Draft
chore: Remove deprecated FD-tracking actions#4700ariosmon wants to merge 1 commit intocilium:mainfrom
ariosmon wants to merge 1 commit intocilium:mainfrom
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0968eeb to
37ec52a
Compare
The FollowFD, UnfollowFD, and CopyFD actions (values 2, 4, and 6) were deprecated and have been removed from the API and BPF implementation. Updated proto definitions, generated code, documentation, and removed all related BPF map structures and helper functions. Signed-off-by: ariosmon <ariosmon@cisco.com>
37ec52a to
c66095f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES: #4580
Verified the deprecation logic works via standalone daemon testing.
Executing a regular tracing-policy with No deprecated fields checking if the is possible to continue working with regular tracing-policy with correct structure.
Output: after adding this command line: sudo ./tetragon --bpf-lib bpf/objs/ --tracing-policy testdata/fd-install-normal.yaml
Create a tracing-policy to test using the tetragon executable directly to check if the compilation is working after removing code
Create a tracing policy: testdata/deprecated-fd-test-policy.yaml and the output exectation is to get Deprecated message like:
Execute the tracing-policy
Output after executing this command line: sudo ./tetragon --bpf-lib bpf/objs/ --tracing-policy testdata/deprecated-fd-test-policy.yaml
Some Testing in K8s:
I created a Docker image using development code to test the removing code for: FollowFD and friends from BPF implementation works well
Adding the tracing policy:
Helm list:
Logs:
Test 2: Policy with Deprecated Action (FollowFD)
Test 3: Valid Policy (No Warnings)
-- Logs: