Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tetra: Add CEL filter to the CLI #3124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tetra: Add CEL filter to the CLI #3124

wants to merge 1 commit into from

Conversation

knrc
Copy link

@knrc knrc commented Nov 15, 2024 •
edited by kkourt
Loading

Fixes #3112

Description

Integrate the existing CEL filtering capability into the CLI

Changelog

@knrc knrc requested a review from a team as a code owner November 15, 2024 18:42
@knrc knrc requested a review from tpapagian November 15, 2024 18:42
kkourt
kkourt requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the PR!

It seems to me that this PR attempts to add support for CEL filters in the export filters rather than the CLI (tetra). Could you please add more details about what the PR attempts to do? An example of how it works in the commit message would be very helpful in that regard.

@knrc knrc marked this pull request as draft November 18, 2024 14:22
@knrc
Copy link
Author

knrc commented Nov 18, 2024

Hi,

Thanks for the PR!

It seems to me that this PR attempts to add support for CEL filters in the export filters rather than the CLI (tetra). Could you please add more details about what the PR attempts to do? An example of how it works in the commit message would be very helpful in that regard.

Sorry, my mistake. I picked this up at the Contribfest, found that these filters were missing the CEL integration and submitted the fix. I'll tidy this up, and fix the CLI issue, some time over the next few days.

In the meantime I've converted this to a draft

@knrc knrc force-pushed the add-cel-filter-to-cli branch from 192ee0f to 4fab7fe Compare November 28, 2024 17:14
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 4fab7fe
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6748a4ee7c5e2a0008555b4c
😎 Deploy Preview https://deploy-preview-3124--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knrc
Copy link
Author

knrc commented Nov 28, 2024

It seems to me that this PR attempts to add support for CEL filters in the export filters rather than the CLI (tetra). Could you please add more details about what the PR attempts to do? An example of how it works in the commit message would be very helpful in that regard.

@kkourt I've updated the PR to also include the CLI integration, the tetra getevents command will now accept --cel-expression arguments to enable filtering of events by CEL expressions.

@knrc knrc requested a review from kkourt November 28, 2024 17:22
@knrc knrc marked this pull request as ready for review November 28, 2024 17:22
kkourt
kkourt requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you please add an example usage in the commit message?

Also, can you put the "Fixes: " in the PR message" rather than the commit title?

@knrc knrc force-pushed the add-cel-filter-to-cli branch from 4fab7fe to e96ffe8 Compare December 6, 2024 00:50
@knrc
tetra: Add CEL filter to the CLI
4d81dac 
Add the ability to filter events using CEL expressions, for example:

  # tetra getevents --cel-expression "process_exec.process.binary == '/bin/sh'"

Signed-off-by: Kevin Conner <[email protected]>
@knrc knrc force-pushed the add-cel-filter-to-cli branch from e96ffe8 to 4d81dac Compare December 6, 2024 00:51
@knrc knrc changed the title Add CEL filter to the CLI, fixes #3112 tetra: Add CEL filter to the CLI Dec 6, 2024
@knrc
Copy link
Author

knrc commented Dec 6, 2024

Can you please add an example usage in the commit message?

Also, can you put the "Fixes: " in the PR message" rather than the commit title?

Commit message should now be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt requested changes

@olsajiri olsajiri olsajiri approved these changes

@tpapagian tpapagian Awaiting requested review from tpapagian tpapagian is a code owner automatically assigned from cilium/tetragon

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tetra cli: add support for cel_expression filter
3 participants
@knrc @kkourt @olsajiri