Update bpf-next steps in README #73
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested-by: Kornilios Kourtis <[email protected]>
info:
{
"orig_ref": "81c34126326920cd2d5642a503b4403b06750a92",
"tag": "20230705.160505"
}
X-GHA-TAG: 20230705.160505
github-actions
bot
force-pushed
the
update-readme
branch
from
20798d2 to
003f75e
Compare
kkourt
reviewed
Jul 6, 2023
| @@ -22,7 +22,7 @@ $ make images | |||
| => => writing image sha257:96a86e6ebb38238569c007491c3e86a056340ceb9e4a3e66959bfa6a6ca8f8a0 | |||
| => => naming to quay.io/lvh-images/root-images | |||
| $ c=$(docker create sha256:96a86e6ebb38238569c007491c3e86a056340ceb9e4a3e66959bfa6a6ca8f8a0) | |||
| $ docker cp $c:/data/images/base.qcow2.zst /tmp | |||
| $ docker cp $c:/data/images/kind_bpf-next.qcow2.zst /tmp | |||
There was a problem hiding this comment.
I think that's not correct. The original example is about root-images, and kind_bpf-next exists in the kind images. For the kind and complexity-test images, it might make sense to have a symbolic link always pointing to the proper file (since these only contain one image).
There was a problem hiding this comment.
For the README, specifically it might make sense to add an examples for kind and complexity-test images as well.
There was a problem hiding this comment.
Sorry, missed your comments. Sure, I'll extend the README with kind images examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested-by: Kornilios Kourtis [email protected]