Add support for IPv6 in connectivity tests #2545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 0bda11d does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
This commit brings support for IPv6 addresses specified in options --external-ip and --external-other-ip for the cilium connectivity test command. Signed-off-by: Léo El Amri <[email protected]>
lel-amri
force-pushed
the
connectivity-test-ipv6-support
branch
from
0bda11d
to
aa7b502
Compare
christarazi
approved these changes
May 13, 2024
doniacld
reviewed
May 14, 2024
| return net.ParseIP(s) != nil && strings.Contains(s, ":") | ||
| } | ||
|
|
||
| func EnsureIPv6InBackets(s string) string { |
There was a problem hiding this comment.
Nit:
Suggested change
| func EnsureIPv6InBackets(s string) string { | |
| func EnsureIPv6InBrackets(s string) string { |
doniacld
requested changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today, values specified in options
--external-ipand--external-other-ipare assumed to be IPv4 addresses in several places in the code. This cause some tests to fail even when a proper IPv6 configuration is specified with options--external-cidr,--external-ip,--external-other-ipand--external-target. This pull request remove the assumptions that these options holds IPv4 addresses.