Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message send size to perf testing #2314

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

strongjz
Copy link

@strongjz strongjz commented Feb 16, 2024

netperf tests run with a default setting of 1024 bytes for -m setting in netperf. This pr adds a config option to allow user defined testing with different send sizes.

internal/cli/cmd/connectivity.go Outdated Show resolved Hide resolved
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, why ci-structure is required for review.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 17, 2024
@tklauser tklauser removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 21, 2024
@tklauser
Copy link
Member

tklauser commented Mar 5, 2024

@strongjz It looks like this PR picked up a merge conflict. Could you please rebase?

@strongjz
Copy link
Author

strongjz commented Mar 5, 2024

@tklauser done

@tklauser
Copy link
Member

tklauser commented Mar 6, 2024

@strongjz it looks like the build is failing consistently. The connectivity tests were restructured recently in #2322. Might be a consequence of that.

@nickolaev
Copy link
Contributor

@strongjz it looks like the build is failing consistently. The connectivity tests were restructured recently in #2322. Might be a consequence of that.

Maybe the dependency was updated: not enough arguments in call to netperf.Netperf

@tklauser
Copy link
Member

tklauser commented Mar 12, 2024

@strongjz I‘ll move this PR to draft status for now to avoid it from showing up in people‘s review queues. Please feel free to move it out of draft once the build failure is resolved.

@tklauser tklauser marked this pull request as draft March 12, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants