Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs about NaiveDateTime conversion #688

Open
wants to merge 1 commit into
base: 0.5.x
Choose a base branch
from

Conversation

gerritsangel
Copy link

@gerritsangel gerritsangel commented May 7, 2022

This adds some basic explanation on how to convert a NaiveDateTime to a DateTime.

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry
    about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that
    we can't reintroduce it?

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc
Copy link
Contributor

djc commented May 30, 2022

Sorry for the slow review -- would you mind fixing up the lint issues found by CI and the changelog conflict?

@esheppa
Copy link
Collaborator

esheppa commented Jun 10, 2022

Thanks for these changes @gerritsangel - it looks like the lint failure is due to the changes in docs in lib.rs which are then automatically appended to the README.md. This is failed by the lint to prevent out of sync lib.rs docs and README.md being present in the repository.

If possible could you run ci/lint.sh locally and commit the changed README.md in this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants