Add id prop to input element in simple-component.md #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of htmlFor is id (not the input's name), so you have to put the same value into the id of the input. Btw your current example is still working because you are putting the input inside of the label, otherwise, it will not work as expected
|
@dangkhoipro thanks for taking the time to put together this pull request and helping us improve the tutorial. We appreciate it 🙏 ! I've checked and all is good on my end. Sorry for the delayed response, but I was otherwise engaged with some other documentation issues. Hope you have a fantastic day. Stay safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of htmlFor is id (not the input's name), so you have to put the same value into the id of the input. Btw your current example is still working because you are putting the input inside of the label, otherwise, it will not work as expected