Skip to content

[CLN] Revert rust-log-service port to 8000 #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

tanujnay112
Copy link
Contributor

Description of changes

Tilt forwards the rust-frontend-service to local port 3000, which differs from the usual Chroma examples that use port 8000. This is because when Chroma developers were porting the frontend from Python to Rust, the old Python frontend used port 8000. This change makes the Rust frontend port be 8000 now that the Python frontend is gone.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • [ v] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor

propel-code-bot bot commented Jun 14, 2025

Standardize Rust Frontend Service Port to 8000

This PR reverts the rust-frontend-service and all related configuration, test, and infra scripts from using port 3000 back to port 8000, aligning the Rust service with the previous Python frontend and Chroma documentation examples. The change affects Kubernetes port-forwarding, Tiltfile definitions, CI scripts, tests, and code comments to consistently use port 8000 for the rust-frontend-service.

Key Changes:
• Update Tiltfile and .github/actions/tilt/action.yaml to forward rust-frontend-service on 8000:8000 instead of 3000:8000.
• Modify CI workflow (.github/workflows/_python-tests.yml) and infra to use CHROMA_SERVER_HOST=localhost:8000.
• Synchronize Python config (chomadb/config.py) and documentation comments/examples to reference port 8000.
• Adjust Rust backend and test code (server.rs, impls/service_based_frontend.rs) to expect and use port 8000.
• Remove all references to port 3000 for the rust-frontend-service.

Affected Areas:
• Dev/CI infra scripts (Tiltfile, GitHub Actions, Kubernetes configs)
• Python config and documentation
• Rust frontend code and integration tests

This summary was automatically generated by @propel-code-bot

@tanujnay112 tanujnay112 requested a review from HammadB June 14, 2025 00:45
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tanujnay112 tanujnay112 requested a review from codetheweb June 16, 2025 17:01
@tanujnay112 tanujnay112 merged commit b367002 into main Jun 17, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant